]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
repair: fix wrong logic when validating node magic number
authorEryu Guan <eguan@redhat.com>
Sun, 23 Aug 2015 23:21:01 +0000 (09:21 +1000)
committerDave Chinner <david@fromorbit.com>
Sun, 23 Aug 2015 23:21:01 +0000 (09:21 +1000)
commit621b5ffff91aade1c0998c685378bff15e869a94
tree06f46fa00d191529e1817349e14db4e00e10bf62
parent60feae121928e7350eced38d54b3d7f4c93b7466
repair: fix wrong logic when validating node magic number

Magic number is wrong only when != XFS_DA_NODE_MAGIC and
!= XFS_DA3_NODE_MAGIC.

This is triggered by shared/002 when testing 512 block size XFS.

  Phase 1 - find and verify superblock...
  Phase 2 - using internal log
          - scan filesystem freespace and inode maps...
          - found root inode chunk
  Phase 3 - for each AG...
          - scan (but don't clear) agi unlinked lists...
          - process known inodes and perform inode discovery...
          - agno = 0
  bad magic number febe in block 64 (108) for directory inode 35
  ......

Fix it by changing "||" to "&&".

Signed-off-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
repair/attr_repair.c