]> git.ipfire.org Git - thirdparty/qemu.git/commit
backup: add minimum cluster size to performance options
authorFiona Ebner <f.ebner@proxmox.com>
Thu, 11 Jul 2024 12:09:15 +0000 (14:09 +0200)
committerVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Mon, 30 Sep 2024 07:53:08 +0000 (10:53 +0300)
commit6252deb244b2d60d03545c17eec548a43eb3aefa
tree26516077c9dc0021034936bd75ab9ff397d2e42c
parent9484ad6c17a735284d4ff75ed3140ded9e0065fd
backup: add minimum cluster size to performance options

In the context of backup fleecing, discarding the source will not work
when the fleecing image has a larger granularity than the one used for
block-copy operations (can happen if the backup target has smaller
cluster size), because cbw_co_pdiscard_snapshot() will align down the
discard requests and thus effectively ignore then.

To make @discard-source work in such a scenario, allow specifying the
minimum cluster size used for block-copy operations and thus in
particular also the granularity for discard requests to the source.

Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Acked-by: Markus Armbruster <armbru@redhat.com> (QAPI schema)
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-Id: <20240711120915.310243-3-f.ebner@proxmox.com>
[vsementsov: switch version to 9.2 in QAPI doc]
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
block/backup.c
block/copy-before-write.c
block/copy-before-write.h
blockdev.c
qapi/block-core.json