]> git.ipfire.org Git - thirdparty/linux.git/commit
scanf: remove redundant debug logs
authorTamir Duberstein <tamird@gmail.com>
Fri, 7 Mar 2025 11:27:35 +0000 (06:27 -0500)
committerKees Cook <kees@kernel.org>
Fri, 14 Mar 2025 20:50:44 +0000 (13:50 -0700)
commit6340d61b9005de1fab86963ff38c9cfd66e68483
treef37ce612cbb4d6736b991d9dc955c92d6872ec52
parent5866730da7232dca5dc3b91645c964f3ec195c9d
scanf: remove redundant debug logs

Remove `pr_debug` calls which emit information already contained in
`pr_warn` calls that occur on test failure. This reduces unhelpful test
verbosity.

Note that a `pr_debug` removed from `_check_numbers_template` appears to
have been the only guard against silent false positives, but in fact
this condition is handled in `_test`; it is only possible for `n_args`
to be `0` in `_check_numbers_template` if the test explicitly expects it
*and* `vsscanf` returns `0`, matching the expectation.

Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
Link: https://lore.kernel.org/r/20250307-scanf-kunit-convert-v9-2-b98820fa39ff@gmail.com
Signed-off-by: Kees Cook <kees@kernel.org>
lib/test_scanf.c