]> git.ipfire.org Git - people/arne_f/kernel.git/commit
cgroup: set css->id to -1 during init
authorTejun Heo <tj@kernel.org>
Thu, 26 May 2016 19:42:13 +0000 (15:42 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Aug 2016 10:54:46 +0000 (12:54 +0200)
commit65856851b6229563e43e256b3932d5c8513c047b
tree55b881951ebac6b2b3b3fe048212d61dbcf09a65
parent64e7dc481cbb34dcf11623905d54e67fe7ffd035
cgroup: set css->id to -1 during init

commit 8fa3b8d689a54d6d04ff7803c724fb7aca6ce98e upstream.

If percpu_ref initialization fails during css_create(), the free path
can end up trying to free css->id of zero.  As ID 0 is unused, it
doesn't cause a critical breakage but it does trigger a warning
message.  Fix it by setting css->id to -1 from init_and_link_css().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Wenwei Tao <ww.tao0320@gmail.com>
Fixes: 01e586598b22 ("cgroup: release css->id after css_free")
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/cgroup.c