]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false
authorThomas Huth <thuth@redhat.com>
Thu, 7 Sep 2017 12:54:51 +0000 (13:54 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 15 Sep 2017 00:26:40 +0000 (19:26 -0500)
commit65a24b5c448710d1d2cf2ecdaea620793a9437e5
treea78dcf55f949479a64a4d120ba6010ecc64987cf
parent85cdc23e755f1f65a1820fb68a8ed91c1f7b3a1f
hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false

QEMU currently exits unexpectedly when the user accidentially
tries to do something like this:

$ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic
QEMU 2.9.93 monitor - type 'help' for more information
(qemu) device_add allwinner-a10
Unsupported NIC model: smc91c111

Exiting just due to a "device_add" should not happen. Looking closer
at the the realize and instance_init function of this device also
reveals that it is using serial_hds and nd_table directly there, so
this device is clearly not creatable by the user and should be marked
accordingly.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-id: 1503416789-32080-1-git-send-email-thuth@redhat.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit dc89a180caf143a5d596d3f2f776d13be83a687d)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/arm/allwinner-a10.c
scripts/device-crash-test