]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/mips: Have gen_[d]lsa() callers add 1 to shift amount argument
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 12 Nov 2024 15:19:18 +0000 (16:19 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Mon, 14 Jul 2025 22:23:09 +0000 (00:23 +0200)
commit65a67f0fe5adcff442d80efba5094333f7ed7a21
treeb541390e543bbe03e9ab5fe77ad10a93a50e867b
parent23ecff81ac881e18dd06ee87d0c6319244353ade
target/mips: Have gen_[d]lsa() callers add 1 to shift amount argument

Having the callee add 1 to shift amount is misleading (see the
NM_LSA case in decode_nanomips_32_48_opc() where we have to
manually substract 1). Rather have the callers pass a modified
$sa.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20241112172022.88348-4-philmd@linaro.org>
target/mips/tcg/micromips_translate.c.inc
target/mips/tcg/msa_translate.c
target/mips/tcg/nanomips_translate.c.inc
target/mips/tcg/rel6_translate.c
target/mips/tcg/translate_addr_const.c