]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
gdb/dwarf: fix failed assertion in dwarf2_find_containing_comp_unit selftest
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 26 Feb 2025 16:52:32 +0000 (11:52 -0500)
committerSimon Marchi <simon.marchi@efficios.com>
Thu, 27 Feb 2025 15:15:34 +0000 (10:15 -0500)
commit661a85884f1399b3d6acd4d4314010c163ae2b23
tree1cb3e62750edb0b9a6cf808b547a0d9ffaa08d12
parent39ee8c928551783ac0c5058a04acd3dd4e008854
gdb/dwarf: fix failed assertion in dwarf2_find_containing_comp_unit selftest

Commit 2f0521c0d6f6 ("gdb/dwarf: fix signature_type created with nullptr
section") added some asserts in the dwarf2_per_cu_data constructor to
verify that the passed dwarf2_per_bfd and dwarf2_section_info are not
nullptr.  However, the dummy dwarf2_per_cu_data objects created in the
dwarf2_find_containing_comp_unit selftests are passed nullptr for those
parameters.

I prefer to keep the asserts in place, as protection for the non-test
code and as self documentation, so fix this by passing some dummy
pointers in the test.

Change-Id: Ic7cdc1b976f7506041b651222234eefc998e473a
Reviewed-By: Tom de Vries <tdevries@suse.de>
gdb/dwarf2/read.c