]> git.ipfire.org Git - thirdparty/suricata.git/commit
detect: remove lock from global keyword logic
authorVictor Julien <victor@inliniac.net>
Sun, 24 Jun 2018 09:06:24 +0000 (11:06 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 26 Jun 2018 10:52:06 +0000 (12:52 +0200)
commit663549d02c5dff01b732ec4e496962c21f2a37a7
tree61d08576a549aa8b223e4910c8ef146aab94da9b
parentec77632e84a106ddbcd0baef4e4368b4fe5c5f9e
detect: remove lock from global keyword logic

The global keyword registration and per thread init handling used
the lock from the DetectEngineMasterCtx. This lead to a dead lock
situation at multi-tenancy tenant reloads.

The lock was unnecessary however, as the only time the registration
list is updated is at engine initialization. At that time Suricata
is still running in a single thread. After this, the data structure
doesn't change anymore.

Bug #2516.
src/detect-engine.c
src/detect.h