]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commit
ld: aarch64: fix TLS relaxation where TCB_SIZE is used
authorYury Norov <ynorov@caviumnetworks.com>
Sat, 3 Dec 2016 13:20:43 +0000 (18:50 +0530)
committerYury Norov <ynorov@caviumnetworks.com>
Wed, 14 Dec 2016 05:37:24 +0000 (11:07 +0530)
commit6650f7bd18f8161b9f666d3e65a6346e23a9d85f
tree74f3dc686353372f0bcd0d28ec9b2c5999680674
parentfc8e0108db6c60f2ecefb4004cddb94e8824fd42
ld: aarch64: fix TLS relaxation where TCB_SIZE is used

TCB_SIZE is 2*sizeof(void *), which is 0x10 for lp64, and 0x8 for
ilp32. During relaxation, ld goes to do a replace:
bl   __tls_get_addr => add R0, R0, TCB_SIZE

But actual implementation is:
bfd_putl32 (0x91004000, contents + rel->r_offset + 4);

Which is equivalent of add x0, x0, 0x10. This is wrong for ilp32.

The possible fix for it is:
bfd_putl32 (0x91000000 | (TCB_SIZE<<10), contents + rel->r_offset + 4);

But ilp32 also needs w-registers, so it's simpler to put proper
instruction in #if/#else condition.

THere are 2 such relaxations in elfNN_aarch64_tls_relax(), and so 2 new
tests added for ilp32 mode to test it.

Yury
bfd/elfnn-aarch64.c
ld/testsuite/ld-aarch64/aarch64-elf.exp
ld/testsuite/ld-aarch64/tls-relax-ld-le-small-ilp32.d [new file with mode: 0644]
ld/testsuite/ld-aarch64/tls-relax-ld-le-tiny-ilp32.d [new file with mode: 0644]