]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Disallow starting server with insufficient wal_level for existing slot.
authorAndres Freund <andres@anarazel.de>
Wed, 31 Oct 2018 21:47:41 +0000 (14:47 -0700)
committerAndres Freund <andres@anarazel.de>
Wed, 31 Oct 2018 22:46:40 +0000 (15:46 -0700)
commit679cb44e4b563a1af6049a482db56aa02809d80c
tree6097417bffea83e0fda798e12e02f757a3a11ace
parent156a737a6b7387805633194d8549c0fa6cc900ed
Disallow starting server with insufficient wal_level for existing slot.

Previously it was possible to create a slot, change wal_level, and
restart, even if the new wal_level was insufficient for the
slot. That's a problem for both logical and physical slots, because
the necessary WAL records are not generated.

This removes a few tests in newer versions that, somewhat
inexplicably, whether restarting with a too low wal_level worked (a
buggy behaviour!).

Reported-By: Joshua D. Drake
Author: Andres Freund
Discussion: https://postgr.es/m/20181029191304.lbsmhshkyymhw22w@alap3.anarazel.de
Backpatch: 9.4-, where replication slots where introduced
src/backend/replication/logical/logical.c
src/backend/replication/slot.c