]> git.ipfire.org Git - thirdparty/qemu.git/commit
monitor error: Make printf()-like functions return a value
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Apr 2019 19:06:36 +0000 (21:06 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 18 Apr 2019 20:18:59 +0000 (22:18 +0200)
commit679cb8e1a1e5d10f44ac9e40fe1458cbfd720ebb
tree388f5556a444d8037c3b48fe05ccc41cddbe2591
parent26eaf2cd0dd31d7bdb2a5ac53f32a051754b0c30
monitor error: Make printf()-like functions return a value

printf() & friends return the number of characters written on success,
negative value on error.

monitor_printf(), monitor_vfprintf(), monitor_vprintf(),
error_printf(), error_printf_unless_qmp(), error_vprintf(), and
error_vprintf_unless_qmp() return void.  Some of them carry a TODO
comment asking for int instead.

Improve them to return int like printf() does.

This makes our use of monitor_printf() as fprintf_function slightly
less dirty: the function cast no longer adds a return value that isn't
there.  It still changes a parameter's pointer type.  That will be
addressed in a future commit.

monitor_vfprintf() always returns zero.  Improve it to return the
proper value.

Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20190417190641.26814-11-armbru@redhat.com>
include/monitor/monitor.h
include/qemu/error-report.h
monitor.c
stubs/error-printf.c
util/qemu-error.c