]> git.ipfire.org Git - thirdparty/ipset.git/commit
netlink: Bounds-check struct nlmsgerr creation
authorKees Cook <keescook@chromium.org>
Mon, 7 Nov 2022 20:58:52 +0000 (21:58 +0100)
committerJozsef Kadlecsik <kadlec@netfilter.org>
Mon, 7 Nov 2022 20:58:52 +0000 (21:58 +0100)
commit67e1c031e8bae91764ecd100538753c3dabdedb0
treea3971fbc03ef8d24b42b071ee999b86258d984f2
parent6aa65d00f6a7305310eec05218b9ab9dea396658
netlink: Bounds-check struct nlmsgerr creation

In preparation for FORTIFY_SOURCE doing bounds-check on memcpy(),
switch from __nlmsg_put to nlmsg_put(), and explain the bounds check
for dealing with the memcpy() across a composite flexible array struct.
Avoids this future run-time warning:

  memcpy: detected field-spanning write (size 32) of single field "&errmsg->msg" at net/netlink/af_netlink.c:2447 (size 16)

Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: syzbot <syzkaller@googlegroups.com>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220901071336.1418572-1-keescook@chromium.org
Signed-off-by: David S. Miller <davem@davemloft.net>
kernel/net/netfilter/ipset/ip_set_core.c