]> git.ipfire.org Git - thirdparty/lxc.git/commit
Improper pty permissions - missing mode=0620, gid=5
authorStéphane Graber <stgraber@ubuntu.com>
Tue, 15 Oct 2013 18:54:41 +0000 (14:54 -0400)
committerSerge Hallyn <serge.hallyn@ubuntu.com>
Wed, 16 Oct 2013 16:47:14 +0000 (11:47 -0500)
commit67e5a20ad1b5579a571f43f7dd8a1556a8bea7a1
tree6a9b7c5679bdb18afe01670b877d670f75408722
parentc414be2526c8f9aae28f485ff542c85e335d50ad
Improper pty permissions - missing mode=0620, gid=5

This fix is coming from Debian bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=720122

The reason for the hardcoded gid= and mode= is because of the fix for
CVE-2013-2207 which removes pt_chown from glibc and so requires proper
write access to devpts.

It looks like the "tty" group is guaranteed to be gid=5 on at least all
RedHat based and Debian based systems. So this hardcode gid shouldn't be
a big problem. If we however support any distro where that's not the
case, we'll need to implement an extra lxc.conf option and matching
template changes.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
src/lxc/conf.c