]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/amdgpu: Fix SDMA engine reset with logical instance ID
authorJesse Zhang <jesse.zhang@amd.com>
Wed, 11 Jun 2025 07:02:09 +0000 (15:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Aug 2025 08:51:28 +0000 (09:51 +0100)
commit67fe85e81728977b72d0eaac3b89b92e8a9947c0
tree46a12e589632f010c454175c32670154abc4d3b7
parentf201a41ab791c63d7ace5c8822f08d7005d6ff36
drm/amdgpu: Fix SDMA engine reset with logical instance ID

commit 09b585592fa481384597c81388733aed4a04dd05 upstream.

This commit makes the following improvements to SDMA engine reset handling:

1. Clarifies in the function documentation that instance_id refers to a logical ID
2. Adds conversion from logical to physical instance ID before performing reset
   using GET_INST(SDMA0, instance_id) macro
3. Improves error messaging to indicate when a logical instance reset fails
4. Adds better code organization with blank lines for readability

The change ensures proper SDMA engine reset by using the correct physical
instance ID while maintaining the logical ID interface for callers.

V2: Remove harvest_config check and convert directly to physical instance (Lijo)

Suggested-by: Jonathan Kim <jonathan.kim@amd.com>
Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit 5efa6217c239ed1ceec0f0414f9b6f6927387dfc)
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c