]> git.ipfire.org Git - thirdparty/qemu.git/commit
target/i386: remove unnecessary/wrong application of the A20 mask
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 22 Dec 2023 08:52:27 +0000 (09:52 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 28 Feb 2024 18:18:45 +0000 (21:18 +0300)
commit6801a20ebd0e541f45855665a75571d4d24188a0
tree6855c0781c7c128217671dbbc8db6e9011d30d78
parenta28b6b4e7431a7557958a8b105626a5a5958791c
target/i386: remove unnecessary/wrong application of the A20 mask

If ptw_translate() does a MMU_PHYS_IDX access, the A20 mask is already
applied in get_physical_address(), which is called via probe_access_full()
and x86_cpu_tlb_fill().

If ptw_translate() on the other hand does a MMU_NESTED_IDX access,
the A20 mask must not be applied to the address that is looked up in
the nested page tables; it must be applied only to the addresses that
hold the NPT entries (which is achieved via MMU_PHYS_IDX, per the
previous paragraph).

Therefore, we can remove A20 masking from the computation of the page
table entry's address, and let get_physical_address() or mmu_translate()
apply it when they know they are returning a host-physical address.

Cc: qemu-stable@nongnu.org
Fixes: 4a1e9d4d11c ("target/i386: Use atomic operations for pte updates", 2022-10-18)
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit a28fe7dc1939333c81b895cdced81c69eb7c5ad0)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/i386/tcg/sysemu/excp_helper.c