]> git.ipfire.org Git - thirdparty/gcc.git/commit
libstdc++: Do not allocate a zero-size vector<bool> [PR 100153]
authorJonathan Wakely <jwakely@redhat.com>
Tue, 20 Apr 2021 15:16:13 +0000 (16:16 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Fri, 1 Oct 2021 19:34:46 +0000 (20:34 +0100)
commit681707ec28d56494fa61a80c62500724d55f8586
treeac6dcf1d3e62b31878d9dc4260b65629d7435561
parent741c7350c08b0884689466867b6c9e711c7b109e
libstdc++: Do not allocate a zero-size vector<bool> [PR 100153]

The vector<bool>::shrink_to_fit() implementation will allocate new
storage even if the vector is empty. That then leads to the
end-of-storage pointer being non-null and equal to the _M_start._M_p
pointer, which means that _M_end_addr() has undefined behaviour.

The fix is to stop doing a useless zero-sized allocation in
shrink_to_fit(), so that _M_start._M_p and _M_end_of_storage are both
null after an empty vector shrinks.

Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:

PR libstdc++/100153
* include/bits/vector.tcc (vector<bool>::_M_shrink_to_fit()):
When size() is zero just deallocate and reset.
libstdc++-v3/include/bits/vector.tcc