]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: add {READ|WRITE}_ONCE() annotations on ->rskq_accept_head
authorEric Dumazet <edumazet@google.com>
Wed, 9 Oct 2019 21:51:20 +0000 (14:51 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:46:50 +0000 (14:46 +0100)
commit681c8c92c4b78e80e0853f8e18861e93069d68e6
tree11f744efc2ae03e68142de218df611ac276f3e15
parent2ffb5a9b396d7857600fdf94432a94490c0cae71
net: add {READ|WRITE}_ONCE() annotations on ->rskq_accept_head

[ Upstream commit 60b173ca3d1cd1782bd0096dc17298ec242f6fb1 ]

reqsk_queue_empty() is called from inet_csk_listen_poll() while
other cpus might write ->rskq_accept_head value.

Use {READ|WRITE}_ONCE() to avoid compiler tricks
and potential KCSAN splats.

Fixes: fff1f3001cc5 ("tcp: add a spinlock to protect struct request_sock_queue")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/xen/pvcalls-back.c
include/net/request_sock.h
net/ipv4/inet_connection_sock.c