]> git.ipfire.org Git - thirdparty/linux.git/commit
netfilter: nf_tables: don't unregister hook when table is dormant
authorFlorian Westphal <fw@strlen.de>
Tue, 1 Apr 2025 12:36:47 +0000 (14:36 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 2 Apr 2025 20:51:08 +0000 (22:51 +0200)
commit688c15017d5cd5aac882400782e7213d40dc3556
tree1919139f594c24c6dcdd9d240bdb2dd31447fd38
parent9d74da1177c800eb3d51c13f9821b7b0683845a5
netfilter: nf_tables: don't unregister hook when table is dormant

When nf_tables_updchain encounters an error, hook registration needs to
be rolled back.

This should only be done if the hook has been registered, which won't
happen when the table is flagged as dormant (inactive).

Just move the assignment into the registration block.

Reported-by: syzbot+53ed3a6440173ddbf499@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=53ed3a6440173ddbf499
Fixes: b9703ed44ffb ("netfilter: nf_tables: support for adding new devices to an existing netdev chain")
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_tables_api.c