]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw: misc: edu: fix 2 off-by-one errors
authorChris Friedt <chrisfriedt@gmail.com>
Tue, 18 Oct 2022 12:25:49 +0000 (08:25 -0400)
committerThomas Huth <thuth@redhat.com>
Tue, 30 Apr 2024 04:21:47 +0000 (06:21 +0200)
commit69826741593644f6e9ee735cff37599c33764d67
tree6b137af3b2642e36dc9ae8ff3c11c089ba908da9
parent046bf2a6184f0a87b89b735ef77edd9a13a96656
hw: misc: edu: fix 2 off-by-one errors

In the case that size1 was zero, because of the explicit
'end1 > addr' check, the range check would fail and the error
message would read as shown below. The correct comparison
is 'end1 >= addr'.

EDU: DMA range 0x40000-0x3ffff out of bounds (0x40000-0x40fff)!

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1254
Signed-off-by: Chris Friedt <cfriedt@meta.com>
[thuth: Adjust patch with regards to the "end1 <= end2" check]
Message-ID: <20221018122551.94567-1-cfriedt@meta.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
hw/misc/edu.c