]> git.ipfire.org Git - thirdparty/qemu.git/commit
blockdev: Fix 'change' for slot devices
authorMax Reitz <mreitz@redhat.com>
Fri, 29 Jan 2016 19:49:11 +0000 (20:49 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 17 Mar 2016 21:23:54 +0000 (16:23 -0500)
commit6a49a71cc652431538ba7ed00379fbaab1e7343c
treef0444f6828ff3be9683fdad793da74252695e7cd
parente1a8a0912489d667ab7b35f8dd6ae9ec1de7ca20
blockdev: Fix 'change' for slot devices

'change' and related operations did not work when used on guest devices
featuring removable media but no actual tray, because
blk_dev_is_tray_open() always returned false for them and the
blockdev-{insert,remove}-medium commands required it to return true.

Fix this by making blockdev-{insert,remove}-medium work on tray-less
devices. Also, blockdev-{open,close}-tray are now explicitly no-ops when
invoked on such devices, and blk_dev_change_media_cb() is instead
called by blockdev-{insert,remove}-medium (for tray-less devices only).

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-id: 1454096953-31773-3-git-send-email-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
(cherry picked from commit 12c7ec87a7d88919b23736176eba3118d1521372)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
blockdev.c
qapi/block-core.json