]> git.ipfire.org Git - thirdparty/qemu.git/commit
migration/multifd: Fix leaking of Error in TLS error flow
authorAvihai Horon <avihaih@nvidia.com>
Sun, 31 Dec 2023 09:30:12 +0000 (11:30 +0200)
committerPeter Xu <peterx@redhat.com>
Thu, 4 Jan 2024 01:52:42 +0000 (09:52 +0800)
commit6ae208ce9656114e428b1a75ac62a6761ed3216c
treedb4c4164712f1b9dc5b47d27b6f8902ae2a96e68
parenta4395f5d3c06472ed70d9ef9f79878f95575be9e
migration/multifd: Fix leaking of Error in TLS error flow

If there is an error in multifd TLS handshake task,
multifd_tls_outgoing_handshake() retrieves the error with
qio_task_propagate_error() but never frees it.

Fix it by freeing the obtained Error.

In addition, the error is not reported at all, so report it with
migrate_set_error().

Fixes: 29647140157a ("migration/tls: add support for multifd tls-handshake")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20231231093016.14204-8-avihaih@nvidia.com
Signed-off-by: Peter Xu <peterx@redhat.com>
migration/multifd.c