]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
USB: serial: keyspan_pda: fix information leak
authorJohan Hovold <johan@kernel.org>
Mon, 29 Jun 2026 12:45:26 +0000 (14:45 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 30 Jun 2026 08:36:06 +0000 (10:36 +0200)
commit6bfc8d01ac4068eced509f8fc74d0cd205e4dcec
tree1041eebc31c36bc80fef2cafc6011dacfae63620
parentb33ab1dd80f5c1742f49eb6ec7b337c5ffcf3d32
USB: serial: keyspan_pda: fix information leak

The write() callback is supposed to return the number of characters
accepted or a negative errno. Since the addition of write fifo support
the keyspan_pda implementation will however return the number characters
submitted to the device if the write urb is not already in use. If this
number is larger than the number of characters passed to write(), the
line discipline continues writing data from beyond the tty write buffer.

Fix the information leak by making sure that keyspan_pda_write_start()
returns zero on success as intended.

Fixes: 034e38e8f687 ("USB: serial: keyspan_pda: add write-fifo support")
Cc: stable@vger.kernel.org # 5.11
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/keyspan_pda.c