]> git.ipfire.org Git - thirdparty/qemu.git/commit
block: Call attention to truncation of long NBD exports
authorEric Blake <eblake@redhat.com>
Mon, 8 Jun 2020 18:26:38 +0000 (13:26 -0500)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 16 Jun 2020 01:29:36 +0000 (20:29 -0500)
commit6c75ddf4a9f317f038a4d94da1b2989fef5dd93b
tree7cf657d334e441bad4ce6295868e5d707420dc2b
parentd6d45d9ed1754dea6827f98d8487b3aa0bb56714
block: Call attention to truncation of long NBD exports

Commit 93676c88 relaxed our NBD client code to request export names up
to the NBD protocol maximum of 4096 bytes without NUL terminator, even
though the block layer can't store anything longer than 4096 bytes
including NUL terminator for display to the user.  Since this means
there are some export names where we have to truncate things, we can
at least try to make the truncation a bit more obvious for the user.
Note that in spite of the truncated display name, we can still
communicate with an NBD server using such a long export name; this was
deemed nicer than refusing to even connect to such a server (since the
server may not be under our control, and since determining our actual
length limits gets tricky when nbd://host:port/export and
nbd+unix:///export?socket=/path are themselves variable-length
expansions beyond the export name but count towards the block layer
name length).

Reported-by: Xueqiang Wei <xuwei@redhat.com>
Fixes: https://bugzilla.redhat.com/1843684
Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200610163741.3745251-3-eblake@redhat.com>
(cherry picked from commit 5c86bdf1208916ece0b87e1151c9b48ee54faa3e)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block.c
block/nbd.c