]> git.ipfire.org Git - thirdparty/openssl.git/commit
test/wpackettest.c: remove bogus cleanup() in test_WPACKET_quic_vlint_random()
authorEugene Syromiatnikov <esyr@openssl.org>
Mon, 15 Sep 2025 02:05:04 +0000 (04:05 +0200)
committerTomas Mraz <tomas@openssl.org>
Thu, 25 Sep 2025 15:00:25 +0000 (17:00 +0200)
commit6d79dec2eb86d73fdf0dfbd974b0cd77b63a457e
tree7ffa79fd43f939bb9ca786e12c154a474aad1ea3
parent1676ac44be474836da3970458c00d48604ec4cac
test/wpackettest.c: remove bogus cleanup() in test_WPACKET_quic_vlint_random()

In the beginning of the iteration, pkt is not initialised yet, so there
is no need to clean it up on RAND_bytes() failure.  Replace
"return cleanup(&pkt)" with plain "return 0".

Fixes: 416d0a638c16 "QUIC wire format support"
Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1665422
References: https://github.com/openssl/project/issues/1432
Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/28648)

(cherry picked from commit 68f7f1295a77b5ca3b37b71a4079d7fe26bcd1c3)
test/wpackettest.c