]> git.ipfire.org Git - thirdparty/libvirt.git/commit
domcaps: Check for architecture more wisely
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 8 Apr 2015 14:59:36 +0000 (16:59 +0200)
committerCole Robinson <crobinso@redhat.com>
Mon, 27 Apr 2015 23:57:36 +0000 (19:57 -0400)
commit6d79e8b3ace762c6a75e7eea537f8439e2c7def8
tree1a890d820cb7925c7927afa76179d79e3e784136
parent5a37b2a6395920f52b48b8476a0f2d2145cdcd9a
domcaps: Check for architecture more wisely

https://bugzilla.redhat.com/show_bug.cgi?id=1209948

So we have this bug. The virConnectGetDomainCapabilities() API
performs a couple of checks before it produces any result. One of
the checks is if the architecture requested by user can be run by
the binary (again user provided). However, the check is pretty
dumb. It merely compares if the default binary architecture
matches the one provided by user. However, a qemu binary can run
multiple architectures. For instance: qemu-system-ppc64 can run:
ppc, ppcle, ppc64, ppc64le and ppcemb. The default is ppc64, so
if user requested something else, like ppc64le, the check would
have failed without obvious reason.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
(cherry picked from commit 0af9325e6a06fd4478d4eebfcd92dfe7e2ec570c)
src/qemu/qemu_driver.c