]> git.ipfire.org Git - thirdparty/qemu.git/commit
Revert "hw/riscv/virt.c: imsics DT: add '#msi-cells'"
authorAndrew Jones <ajones@ventanamicro.com>
Fri, 16 Aug 2024 16:07:45 +0000 (18:07 +0200)
committerAlistair Francis <alistair.francis@wdc.com>
Mon, 19 Aug 2024 04:34:49 +0000 (14:34 +1000)
commit6df664f87c738788891f3bda701e63e23a0dbbc2
treea32c832f7525c1ce2c50c040cec69cbc96f79c5a
parent2eefd4fcec4b8fe41ceee2a8f00cdec1fe81b75c
Revert "hw/riscv/virt.c: imsics DT: add '#msi-cells'"

This reverts commit f42cdf2ea5b3a1dc369792d7acbf9cd3e5c90815.

Linux does not properly handle '#msi-cells=<0>' when searching for
MSI controllers for PCI devices which results in the devices being
unable to use MSIs. A patch for Linux has been sent[1] but until it,
or something like it, is merged and in distro kernels we should stop
adding the property. It's harmless to stop adding it since the
absence of the property and a value of zero for the property mean
the same thing according to the DT binding definition.

Link: https://lore.kernel.org/all/20240816124957.130017-2-ajones@ventanamicro.com/
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Message-ID: <20240816160743.220374-5-ajones@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/riscv/virt.c