]> git.ipfire.org Git - thirdparty/openvpn.git/commit
NTLM: increase size of phase 2 response we can handle
authorFrank Lichtenheld <frank@lichtenheld.com>
Wed, 17 Jan 2024 09:08:39 +0000 (10:08 +0100)
committerGert Doering <gert@greenie.muc.de>
Wed, 17 Jan 2024 09:52:01 +0000 (10:52 +0100)
commit6e010d4824b7251d817cf1770e80f186000b99ae
tree68d42ca180ca5d6bf24ce0ce9d25de06f02a8400
parenta021de2aabb21a24c7b69aaae1c710a9b6fee429
NTLM: increase size of phase 2 response we can handle

With NTLMv2 the target information buffer can be rather large
even with normal domain setups.

In my test setup it was 152 bytes starting at offset 71.
Overall the base64 encode phase 2 response was 300 byte long.
The linked documentation has 98 bytes at offset 60. 128 byte
is clearly too low.

While here improve the error messaging, so that if the buffer
is too small at least one can determine that in the log.

Change-Id: Iefa4930cb1e8c4135056a17ceb4283fc13cc75c8
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20240117090840.32621-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28040.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/ntlm.c
src/openvpn/proxy.c