]> git.ipfire.org Git - thirdparty/qemu.git/commit
seccomp: use SIGSYS signal instead of killing the thread
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Wed, 22 Aug 2018 17:02:47 +0000 (19:02 +0200)
committerEduardo Otubo <otubo@redhat.com>
Thu, 23 Aug 2018 14:45:20 +0000 (16:45 +0200)
commit6f2231e9b0931e1998d9ed0c509adf7aedc02db2
tree62e40bd7df6af9eae13d636c65b111ae72621022
parent3392fbee4e435658733bbe9aab23392660558b59
seccomp: use SIGSYS signal instead of killing the thread

The seccomp action SCMP_ACT_KILL results in immediate termination of
the thread that made the bad system call. However, qemu being
multi-threaded, it keeps running. There is no easy way for parent
process / management layer (libvirt) to know about that situation.

Instead, the default SIGSYS handler when invoked with SCMP_ACT_TRAP
will terminate the program and core dump.

This may not be the most secure solution, but probably better than
just killing the offending thread. SCMP_ACT_KILL_PROCESS has been
added in Linux 4.14 to improve the situation, which I propose to use
by default if available in the next patch.

Related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1594456

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Eduardo Otubo <otubo@redhat.com>
qemu-seccomp.c