]> git.ipfire.org Git - thirdparty/curl.git/commit
lib: include necessary headers for `inet_ntop`/`inet_pton`
authorViktor Szakats <commit@vsz.me>
Wed, 5 Feb 2025 14:32:11 +0000 (15:32 +0100)
committerViktor Szakats <commit@vsz.me>
Wed, 5 Feb 2025 15:29:03 +0000 (16:29 +0100)
commit6fc703904b2ed5e320abd66c9ef1efc894578fe9
tree458fd91305eca9edc4deaba9e22f16d5f9d4dbd2
parent14f26f5ee78204c15bf906f3cf7480308e2feb28
lib: include necessary headers for `inet_ntop`/`inet_pton`

Include `netinet/in.h` for FreeBSD/OpenBSD. Also include `sys/socket.h`
just in case, based on earlier code in `tests/libtest/lib1960.c`.

Also:
- document these in `CMakeLists.txt`.
- add a CI job testing FreeBSD with no unity and no test bundles.
  (without running tests to keep it fast)

FreeBSD (autotools):
```
../../../tests/libtest/lib1960.c:66:22: error: variable has incomplete type 'struct sockaddr_in'
   66 |   struct sockaddr_in serv_addr;
      |                      ^
../../../tests/libtest/lib1960.c:66:10: note: forward declaration of 'struct sockaddr_in'
   66 |   struct sockaddr_in serv_addr;
      |          ^
```
Ref: https://github.com/curl/curl/actions/runs/13159721509/job/36725114118?pr=16188#step:3:5289

OpenBSD (cmake):
```
/home/runner/work/curl/curl/tests/libtest/lib1960.c:66:22: error: variable has incomplete type 'struct sockaddr_in'
  struct sockaddr_in serv_addr;
                     ^
/home/runner/work/curl/curl/tests/libtest/lib1960.c:66:10: note: forward declaration of 'struct sockaddr_in'
  struct sockaddr_in serv_addr;
         ^
1 error generated.
```
Ref: https://github.com/curl/curl/actions/runs/13159721509/job/36725102004?pr=16188#step:3:2166

Reported-by: CueXXIII on Github
Fixes #16184
Follow-up to a3585c9576abccddbd27200058912cef900c3c0f #15543
Closes #16188
.github/workflows/non-native.yml
CMakeLists.txt
lib/inet_ntop.h
lib/inet_pton.h