]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/intc/arm_gicv3: Add cast to match the documentation
authorAlexandra Diupina <adiupina@astralinux.ru>
Mon, 14 Oct 2024 16:05:50 +0000 (17:05 +0100)
committerMichael Tokarev <mjt@tls.msk.ru>
Tue, 15 Oct 2024 16:40:19 +0000 (19:40 +0300)
commit6fecfc5978e25c2298eed4aa0f254ac7a0384d81
treee6f95149f473477bd2f651e91c50c38e7fc314d5
parentc5f652a0532961c20bd5ba78a65288209605b522
hw/intc/arm_gicv3: Add cast to match the documentation

The result of 1 << regbit with regbit==31 has a 1 in the 32nd bit.
When cast to uint64_t (for further bitwise OR), the 32 most
significant bits will be filled with 1s. However, the documentation
states that the upper 32 bits of ICC_AP[0/1]R<n>_EL2 are reserved.

Add an explicit cast to match the documentation.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Cc: qemu-stable@nongnu.org
Fixes: 28cca59c46 ("hw/intc/arm_gicv3: Add NMI handling CPU interface registers")
Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
(cherry picked from commit 12dc8f6eca1ead876142fd3d6731cf3da1295f2a)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/intc/arm_gicv3_cpuif.c