]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
userns: Use kgids for sysctl_ping_group_range
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 24 May 2012 16:34:21 +0000 (10:34 -0600)
committerEric W. Biederman <ebiederm@xmission.com>
Wed, 15 Aug 2012 04:49:10 +0000 (21:49 -0700)
commit7064d16e162adf8199f0288b694e6af823ed5431
tree02563996ee28d686b1cb9a16ba389b382aa6bb4f
parenta7cb5a49bf64ba64864ae16a6be028f8b0d3cc06
userns: Use kgids for sysctl_ping_group_range

- Store sysctl_ping_group_range as a paire of kgid_t values
  instead of a pair of gid_t values.
- Move the kgid conversion work from ping_init_sock into ipv4_ping_group_range
- For invalid cases reset to the default disabled state.

With the kgid_t conversion made part of the original value sanitation
from userspace understand how the code will react becomes clearer
and it becomes possible to set the sysctl ping group range from
something other than the initial user namespace.

Cc: Vasiliy Kulikov <segoon@openwall.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
include/net/netns/ipv4.h
init/Kconfig
net/ipv4/ping.c
net/ipv4/sysctl_net_ipv4.c