]> git.ipfire.org Git - thirdparty/shadow.git/commit
semanage: disconnect to free libsemanage internals
authorChristian Göttsche <cgzones@googlemail.com>
Sat, 1 Apr 2023 12:11:06 +0000 (14:11 +0200)
committerSerge Hallyn <serge@hallyn.com>
Wed, 26 Apr 2023 22:52:54 +0000 (17:52 -0500)
commit7078ed1e0b8a197aa9e5103986bce927abef87a4
treeca515f03da929daf6812883334b4eaded7482f86
parenta8dd8ce6c9a5f6e69ed4e9fa7b0c0976bb4ba332
semanage: disconnect to free libsemanage internals

Destroying the handle does not actually disconnect, see [1].
Also free the key on user removal.

[1]: https://github.com/SELinuxProject/selinux/blob/e9072e7d45f4559887d11b518099135cbe564163/libsemanage/src/direct_api.c#L330

Example adduser leak:

    Direct leak of 1008 byte(s) in 14 object(s) allocated from:
        #0 0x5638f2e782ae in __interceptor_malloc (./src/useradd+0xee2ae)
        #1 0x7fb5cfffad09 in dbase_file_init src/database_file.c:170:45

    Direct leak of 392 byte(s) in 7 object(s) allocated from:
        #0 0x5638f2e782ae in __interceptor_malloc (./src/useradd+0xee2ae)
        #1 0x7fb5cfffc929 in dbase_policydb_init src/database_policydb.c:187:27

    Direct leak of 144 byte(s) in 2 object(s) allocated from:
        #0 0x5638f2e782ae in __interceptor_malloc (./src/useradd+0xee2ae)
        #1 0x7fb5cfffb519 in dbase_join_init src/database_join.c:249:28

    [...]
lib/semanage.c