]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix over-eager ping'ing in logical replication receiver.
authorTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Sep 2020 00:20:05 +0000 (20:20 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Sat, 5 Sep 2020 00:20:05 +0000 (20:20 -0400)
commit7156a0eac3aff743cf0e0972db58c8fffe55cbfc
tree25d6dcd1ffcea586c25fcef3bf388f4f92e6c31a
parentcb9d1faa4a7dca9b28f4a21cc9b2c25287eb74d5
Fix over-eager ping'ing in logical replication receiver.

Commit 3f60f690f only partially fixed the broken-status-tracking
issue in LogicalRepApplyLoop: we need ping_sent to have the same
lifetime as last_recv_timestamp.  The effects are much less serious
than what that commit fixed, though.  AFAICS this would just lead to
extra ping requests being sent, once per second until the sender
responds.  Still, it's a bug, so backpatch to v10 as before.

Discussion: https://postgr.es/m/959627.1599248476@sss.pgh.pa.us
src/backend/replication/logical/worker.c