]> git.ipfire.org Git - people/ms/linux.git/commit
i2c-pca: Fix waitforcompletion() return value
authorYegor Yefremov <yegor_sub1@visionsystems.de>
Thu, 30 Sep 2010 12:14:22 +0000 (14:14 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 29 Oct 2010 04:51:25 +0000 (21:51 -0700)
commit738757938c56703f8568b4628291361b8655bb79
treec4bba11d3ad67f68ca79a5646e3e0d2a54973713
parenteafe9c354fde7597834d45a04f79e9057d24ae93
i2c-pca: Fix waitforcompletion() return value

commit 6abb930af064fb1cf4177d32e2c7bfb89eee0fe5 upstream.

ret is still -1, if during the polling read_byte() returns at once
with I2C_PCA_CON_SI set. So ret > 0 would lead *_waitforcompletion()
to return 0, in spite of the proper behavior.

The routine was rewritten, so that ret has always a proper value,
before returning.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/i2c/busses/i2c-pca-isa.c
drivers/i2c/busses/i2c-pca-platform.c