]> git.ipfire.org Git - thirdparty/qemu.git/commit
Revert "ide/ahci: Check for -ECANCELED in aio callbacks"
authorJohn Snow <jsnow@redhat.com>
Mon, 29 Jul 2019 22:36:05 +0000 (18:36 -0400)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 28 Oct 2019 04:28:24 +0000 (23:28 -0500)
commit73a5bf472921068e6db10e7e325b7ac46f111834
tree7ce010715e242223951db967722d5d30a2e713cb
parentfbde196c30e4797a51bda046ba514b187963d4ba
Revert "ide/ahci: Check for -ECANCELED in aio callbacks"

This reverts commit 0d910cfeaf2076b116b4517166d5deb0fea76394.

It's not correct to just ignore an error code in a callback; we need to
handle that error and possible report failure to the guest so that they
don't wait indefinitely for an operation that will now never finish.

This ought to help cases reported by Nutanix where iSCSI returns a
legitimate -ECANCELED for certain operations which should be propagated
normally.

Reported-by: Shaju Abraham <shaju.abraham@nutanix.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20190729223605.7163-1-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
(cherry picked from commit 8ec41c4265714255d5a138f8b538faf3583dcff6)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/ide/ahci.c
hw/ide/core.c