]> git.ipfire.org Git - thirdparty/qemu.git/commit
linux-user: call cpu_copy under clone_lock
authorMax Filippov <jcmvbkbc@gmail.com>
Fri, 30 Mar 2018 13:19:58 +0000 (06:19 -0700)
committerMax Filippov <jcmvbkbc@gmail.com>
Sat, 31 Mar 2018 21:06:36 +0000 (14:06 -0700)
commit73a988d957b9142e0a005f4dc87944574f02de51
tree4b3c4412954601e8969178878132da1f5b9f7db9
parent4a6bf7adb92d1b8b7cd3763740b4a5180c0147d5
linux-user: call cpu_copy under clone_lock

cpu_copy adds newly created CPU object to container/machine/unattached,
but does it w/o proper locking. As a result when multiple threads create
threads rapidly QEMU may abort with the following message:

  GLib-CRITICAL **: g_hash_table_iter_next: assertion
  'ri->version == ri->hash_table->version' failed

  ERROR:qemu/qom/object.c:1663:object_get_canonical_path_component:
  code should not be reached

E.g. this issue is observed when running glibc test nptl/tst-eintr1.
Move cpu_copy invocation under clone_lock to fix that.

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
linux-user/syscall.c