]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't spuriously report FD_SETSIZE exhaustion on Windows.
authorNoah Misch <noah@leadboat.com>
Sat, 14 Oct 2023 22:54:46 +0000 (15:54 -0700)
committerNoah Misch <noah@leadboat.com>
Sat, 14 Oct 2023 22:54:50 +0000 (15:54 -0700)
commit73cda80a30a552c718f272379476a63d75327fda
treeeffbf1875f77767c9244f386f36c5c299463e621
parent3cc0c25172b201f51dbd8cf2acfd1bfaff66e0d2
Don't spuriously report FD_SETSIZE exhaustion on Windows.

Starting on 2023-08-03, this intermittently terminated a "pgbench -C"
test in CI.  It could affect a high-client-count "pgbench" without "-C".
While parallel reindexdb and vacuumdb reach the same problematic check,
sufficient client count and/or connection turnover is less plausible for
them.  Given the lack of examples from the buildfarm or from manual
builds, reproducing this must entail rare operating system
configurations.  Also correct the associated error message, which was
wrong for non-Windows.  Back-patch to v12, where the pgbench check first
appeared.  While v11 vacuumdb has the problematic check, reaching it
with typical vacuumdb usage is implausible.

Reviewed by Thomas Munro.

Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com
src/bin/pgbench/pgbench.c
src/bin/scripts/vacuumdb.c