]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/arm/smmuv3: Fix potential integer overflow (CID 1432363)
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Mon, 2 Nov 2020 16:52:16 +0000 (16:52 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 2 Nov 2020 16:52:16 +0000 (16:52 +0000)
commit744a790ec01a30033309e6a2155df4d61061e184
tree668a161c5bca234db8fe5b4b347bd6ea1f79b331
parent437588d81d99ac91cb1e4ff060610458e67852d5
hw/arm/smmuv3: Fix potential integer overflow (CID 1432363)

Use the BIT_ULL() macro to ensure we use 64-bit arithmetic.
This fixes the following Coverity issue (OVERFLOW_BEFORE_WIDEN):

  CID 1432363 (#1 of 1): Unintentional integer overflow:

  overflow_before_widen:
    Potentially overflowing expression 1 << scale with type int
    (32 bits, signed) is evaluated using 32-bit arithmetic, and
    then used in a context that expects an expression of type
    hwaddr (64 bits, unsigned).

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20201030144617.1535064-1-philmd@redhat.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/smmuv3.c