]> git.ipfire.org Git - thirdparty/git.git/commit
send-pack: fix push.negotiate with remote helper
authorJonathan Tan <jonathantanmy@google.com>
Thu, 15 Jul 2021 17:44:30 +0000 (10:44 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 15 Jul 2021 18:58:52 +0000 (11:58 -0700)
commit74fab8ff54e6e6a30efa254b8b5322764d119386
treeaae7e266fa53637f32268b603d6c6007ff598b57
parentebf3c04b262aa27fbb97f8a0156c2347fecafafb
send-pack: fix push.negotiate with remote helper

Commit 477673d6f3 ("send-pack: support push negotiation", 2021-05-05)
introduced the push.negotiate config variable and included a test. The
test only covered pushing without a remote helper, so the fact that
pushing with a remote helper doesn't work went unnoticed.

This is ultimately caused by the "url" field not being set in the args
struct. This field being unset probably went unnoticed because besides
push negotiation, this field is only used to generate a "pushee" line in
a push cert (and if not given, no such line is generated). Therefore,
set this field.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/send-pack.c
t/t5549-fetch-push-http.sh [new file with mode: 0755]