]> git.ipfire.org Git - thirdparty/linux.git/commit
dm-crypt: stop constraining max_segment_size to PAGE_SIZE
authorMike Snitzer <snitzer@kernel.org>
Thu, 11 Apr 2024 19:08:05 +0000 (15:08 -0400)
committerMike Snitzer <snitzer@kernel.org>
Tue, 23 Apr 2024 15:19:56 +0000 (11:19 -0400)
commit7560680c8d1e810826d048a61d35668541dce038
tree02e95ee5a280b36d78316c1dfad87a06d2ca1202
parent2285e1496dc68787a626145cfb0904a1b6cc5501
dm-crypt: stop constraining max_segment_size to PAGE_SIZE

This change effectively reverts commit 586b286b110e ("dm crypt:
constrain crypt device's max_segment_size to PAGE_SIZE") and relies on
block core's late bio-splitting to ensure that dm-crypt's encryption
bios are split accordingly if they exceed the underlying device's
limits (e.g. max_segment_size).

Commit 586b286b110e was applied as a 4.3 fix for the benefit of
stable@ kernels 4.0+ just after block core's late bio-splitting was
introduced in 4.3 with commit 54efd50bfd873 ("block: make
generic_make_request handle arbitrarily sized bios"). Given block
core's late bio-splitting it is past time that dm-crypt make use of
it.

Also, given the recent need to revert meaningful progress that was
attempted during the 6.9 merge window (see commit bff4b74625fe Revert
"dm: use queue_limits_set") this change allows DM core to safely make
use of queue_limits_set() without risk of breaking dm-crypt on NVMe.
Though it should be noted this commit isn't a prereq for reinstating
DM core's use of queue_limits_set() because blk_validate_limits() was
made less strict with commit b561ea56a264 ("block: allow device to
have both virt_boundary_mask and max segment size").

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-crypt.c