]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Revert "network: add rule to nftables backend that zeroes checksum of DHCP responses" v10.9.0-rc2
authorLaine Stump <laine@redhat.com>
Wed, 30 Oct 2024 03:21:27 +0000 (23:21 -0400)
committerJiri Denemark <jdenemar@redhat.com>
Wed, 30 Oct 2024 10:39:58 +0000 (11:39 +0100)
commit7581e3b6d5f46deafaf6d8b0b903c6f6b901a031
treefc91335d80da1a53786d975a9a689cbb1cc90057
parent12b456c94b05712a40f9af482a711c01133b3a21
Revert "network: add rule to nftables backend that zeroes checksum of DHCP responses"

This reverts commit 42ab0148dd11727f7e3fd31dce4485469af290d5.

This patch was supposed to fix the checksum of dhcp response packets
by setting it to 0 (because having a non-0 but incorrect checksum was
causing the packets to be droppe on FreeBSD guests).

Early testing was positive, but after the patch was pushed upstream
and more people could test it, it turned out that while it fixed the
dhcp checksum problem for virtio-net interfaces on FreeBSD and
OpenBSD, it also *broke* dhcp checksums for the e1000 emulated NIC on
*all* guests (but not e1000e).

So we're reverting this fix and looking for something more universal
to be included in the next release.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
12 files changed:
src/network/network_nftables.c
tests/networkxml2firewalldata/base.nftables
tests/networkxml2firewalldata/forward-dev-linux.nftables
tests/networkxml2firewalldata/isolated-linux.nftables
tests/networkxml2firewalldata/nat-default-linux.nftables
tests/networkxml2firewalldata/nat-ipv6-linux.nftables
tests/networkxml2firewalldata/nat-ipv6-masquerade-linux.nftables
tests/networkxml2firewalldata/nat-many-ips-linux.nftables
tests/networkxml2firewalldata/nat-port-range-ipv6-linux.nftables
tests/networkxml2firewalldata/nat-port-range-linux.nftables
tests/networkxml2firewalldata/nat-tftp-linux.nftables
tests/networkxml2firewalldata/route-default-linux.nftables