]> git.ipfire.org Git - thirdparty/qemu.git/commit
vfio-ccw: forward halt/clear errors
authorCornelia Huck <cohuck@redhat.com>
Mon, 5 Jul 2021 16:39:51 +0000 (18:39 +0200)
committerThomas Huth <thuth@redhat.com>
Mon, 6 Sep 2021 14:22:54 +0000 (16:22 +0200)
commit759a5d3be0ca447514bc774f97218d3a0a8ed654
tree3922636928c9e7c2fecc99bd345a0c84d8e72300
parent935efca6c246c108253b0e4e51cc87648fc7ca10
vfio-ccw: forward halt/clear errors

hsch and csch basically have two parts: execute the command,
and perform the halt/clear function. For fully emulated
subchannels, it is pretty clear how it will work: check the
subchannel state, and actually 'perform the halt/clear function'
and set cc 0 if everything looks good.

For passthrough subchannels, some of the checking is done
within QEMU, but some has to be done within the kernel. QEMU's
subchannel state may be such that we can perform the async
function, but the kernel may still get a cc != 0 when it is
actually executing the instruction. In that case, we need to
set the condition actually encountered by the kernel; if we
set cc 0 on error, we would actually need to inject an interrupt
as well.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Tested-by: Jared Rossi <jrossi@linux.ibm.com>
Message-Id: <20210705163952.736020-2-cohuck@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
hw/s390x/css.c
hw/vfio/ccw.c