]> git.ipfire.org Git - thirdparty/git.git/commit
git-gui: don't delete source files when auto_mkindex fails
authorJohannes Sixt <j6t@kdbg.org>
Fri, 6 Jun 2025 05:41:42 +0000 (07:41 +0200)
committerJohannes Sixt <j6t@kdbg.org>
Fri, 6 Jun 2025 05:43:37 +0000 (07:43 +0200)
commit765f1db2b5a890c0fa01f8976f197a8483357afe
treed880439ecf9f2e88a89ff023c292f11a92450c9e
parent61f8788fe9d362efb112f69a58cf0510a7e49ee0
git-gui: don't delete source files when auto_mkindex fails

Commit 2cc5b0facfa4 (git-gui: extract script to generate "tclIndex",
2025-03-11) converted commands in a Makefile rule to a shell script.
In this process, the Makefile variable $@ had to be replaced by the
file name that it represents, 'lib/tclIndex'. However, the occurrence
in `rm -f $@` was missed. In a shell script, $@ expands to all
command line arguments, which happen to be the source files lib/*.tcl
in this case. Needless to say that we do not want to remove source
files during a build. Replace $@ by the intended 'lib/tclIndex'.

Reported-by: Randall S. Becker <rsbecker@nexbridge.com>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
generate-tclindex.sh