]> git.ipfire.org Git - thirdparty/libvirt.git/commit
src/logging: no need to include log_protocol.h in log_manager.h
authorPavel Hrdina <phrdina@redhat.com>
Tue, 4 Aug 2020 09:04:04 +0000 (11:04 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Tue, 4 Aug 2020 11:28:22 +0000 (13:28 +0200)
commit76e79e0e77699cc3534290736288840d1e5d8ab4
tree4cc2ba859e91a51bbe915f180b92c2b5bfbed716
parentfdb92c9dac936f54f8211a072fd65105610dc1f5
src/logging: no need to include log_protocol.h in log_manager.h

The header log_manager.h doesn't use anything from log_protocol.h and
the only other place than logging using log_protocol.h is qemu_command.c
where we can include log_protocol.h directly to have enum value
VIR_LOG_MANAGER_PROTOCOL_DOMAIN_OPEN_LOG_FILE_TRUNCATE available.

Fixes race-condition compilation error with meson:

In file included from ../tests/qemuhotplugmock.c:21:
In file included from ../src/qemu/qemu_hotplug.h:25:
In file included from ../src/qemu/qemu_domain.h:42:
../src/logging/log_manager.h:25:10: fatal error: 'logging/log_protocol.h' file not found

         ^~~~~~~~~~~~~~~~~~~~~~~~

1 error generated.

Reported-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/logging/log_manager.h
src/qemu/qemu_command.c