]> git.ipfire.org Git - thirdparty/samba.git/commit
librpc/ndr: let ndr_push_string() let s_len == 0 result in d_len = 0
authorStefan Metzmacher <metze@samba.org>
Wed, 3 Nov 2021 12:57:50 +0000 (13:57 +0100)
committerJule Anger <janger@samba.org>
Sun, 30 Jan 2022 10:57:11 +0000 (10:57 +0000)
commit7734584c4fd5bee49ed564771a16d63f2b005937
tree3ff74a4c2e305b875c00202502f8d6ddd22a6355
parent9be924f907c5215d9452db1cb407c83f39df67a5
librpc/ndr: let ndr_push_string() let s_len == 0 result in d_len = 0

convert_string_talloc_handle() tries to play an the safe side
and always returns a null terminated array.

But for NDR we need to be correct on the wire...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14956

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 43648e95a514020da4c7efa62df55d0882e3db85)
librpc/ndr/ndr_string.c
selftest/knownfail.d/blackbox.ndrdump [new file with mode: 0644]
selftest/knownfail.d/ndr_string [deleted file]