]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
iwlwifi: yoyo: don't add TLV offset when reading FIFOs
authorMordechay Goodstein <mordechay.goodstein@intel.com>
Fri, 6 Mar 2020 13:16:24 +0000 (15:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Apr 2020 07:10:03 +0000 (09:10 +0200)
commit77d4cdf6d29c3ea4478dce85ac13840cf8c4448d
tree669e2248ed77b3bf11f4b87e9f8c3325906a8678
parent6bffa3b0c7396a3ef61a75129bf277c6284320f7
iwlwifi: yoyo: don't add TLV offset when reading FIFOs

commit a5688e600e78f9fc68102bf0fe5c797fc2826abe upstream.

The TLV offset is only used to read registers, while the offset used for
the FIFO addresses are hard coded in the driver and not given by the
TLV.

If we try to apply the TLV offset when reading the FIFOs, we'll read
from invalid addresses, causing the driver to hang.

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Fixes: 8d7dea25ada7 ("iwlwifi: dbg_ini: implement Rx fifos dump")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200306151129.fbab869c26fa.I4ddac20d02f9bce41855a816aa6855c89bc3874e@changeid
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c