]> git.ipfire.org Git - people/arne_f/kernel.git/commit
pwm: tiehrpwm: Update shadow register for disabling PWMs
authorChristoph Vogtländer <c.vogtlaender@sigma-surface-science.com>
Tue, 12 Mar 2019 09:08:46 +0000 (14:38 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Jun 2019 09:54:10 +0000 (11:54 +0200)
commit78002e383be74893741285821917d0689120762a
tree79bcc95fe9f2849be40b5c58e66094254e9c23fb
parent9fdcb04e80e1d7a92c7eb23bc0ba1243bc30ddfd
pwm: tiehrpwm: Update shadow register for disabling PWMs

[ Upstream commit b00ef53053191d3025c15e8041699f8c9d132daf ]

It must be made sure that immediate mode is not already set, when
modifying shadow register value in ehrpwm_pwm_disable(). Otherwise
modifications to the action-qualifier continuous S/W force
register(AQSFRC) will be done in the active register.
This may happen when both channels are being disabled. In this case,
only the first channel state will be recorded as disabled in the shadow
register. Later, when enabling the first channel again, the second
channel would be enabled as well. Setting RLDCSF to zero, first, ensures
that the shadow register is updated as desired.

Fixes: 38dabd91ff0b ("pwm: tiehrpwm: Fix disabling of output of PWMs")
Signed-off-by: Christoph Vogtländer <c.vogtlaender@sigma-surface-science.com>
[vigneshr@ti.com: Improve commit message]
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-tiehrpwm.c