]> git.ipfire.org Git - thirdparty/libvirt.git/commit
network: fix crash when starting a network with no <pf> element
authorLaine Stump <laine@laine.org>
Thu, 14 Aug 2014 16:34:23 +0000 (12:34 -0400)
committerLaine Stump <laine@laine.org>
Fri, 15 Aug 2014 06:42:52 +0000 (02:42 -0400)
commit78096150569ff82994979b05119d9ebeccdabd2e
treed518a553d415b95f8cc97f3562ece6b50bd260fe
parent62c817e516214c56dcf8dea02261b3e9301a373f
network: fix crash when starting a network with no <pf> element

Martin Kletzander pointed out in email that my commit 2a193f64
introduced a crash in networkCreateInterfacePool() during startup of
any network that doesn't have a <pf> subelement of its <forward>
element. He also supplied a patch.

 http://www.redhat.com/archives/libvir-list/2014-August/msg00655.html

I expanded on that patch by cleaning up now-extraneous checks in the
callers of networkCreateInterfacePool().

Fortunately the offending patch hasn't been in any release, and hasn't
been (to my knowledge) backported to any other branch.
src/network/bridge_driver.c