]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Avoid fetching from an already-terminated plan.
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 9 Sep 2021 17:36:31 +0000 (13:36 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 9 Sep 2021 17:36:31 +0000 (13:36 -0400)
commit7813451c20c3b341c8af542d80bb941c9c893825
tree75b32c0d9531186dd985b54d8fe8a9665bd5c5e0
parent1a23b669db576460a42b257379335a447229ffa6
Avoid fetching from an already-terminated plan.

Some plan node types don't react well to being called again after
they've already returned NULL.  PortalRunSelect() has long dealt
with this by calling the executor with NoMovementScanDirection
if it sees that we've already run the portal to the end.  However,
commit ba2c6d6ce overlooked this point, so that persisting an
already-fully-fetched cursor would fail if it had such a plan.

Per report from Tomas Barton.  Back-patch to v11, as the faulty
commit was.  (I've omitted a test case because the type of plan
that causes a problem isn't all that stable.)

Discussion: https://postgr.es/m/CAPV2KRjd=ErgVGbvO2Ty20tKTEZZr6cYsYLxgN_W3eAo9pf5sw@mail.gmail.com
src/backend/commands/portalcmds.c