]> git.ipfire.org Git - thirdparty/git.git/commit
t0000: disable GIT_TEST_FAIL_PREREQS in sub-tests
authorJeff King <peff@peff.net>
Tue, 28 Apr 2020 08:14:21 +0000 (04:14 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 28 Apr 2020 17:26:01 +0000 (10:26 -0700)
commit797e2cfd78155138f3f2a5a72b08c3d1458bc102
treef9ac26cb7f74c23452c094e1a5d1a8ab7f9a51cd
parente870325ee8575d5c3d7afe0ba2c9be072c692b65
t0000: disable GIT_TEST_FAIL_PREREQS in sub-tests

The test added by 477dcaddb6 (tests: do not let lazy prereqs inside
`test_expect_*` turn off tracing, 2020-03-26) runs a sub-test script
that traces a test with a lazy prereq, like:

  test_have_prereq LAZY && echo trace

That won't work if GIT_TEST_FAIL_PREREQS is set in the environment,
because our have_prereq will report failure, and we won't run the echo
at all.

We could work around this by avoiding the &&-chain, but we can
fix this and any future tests at once by unsetting that variable for our
sub-tests. These are meant to be controlled environments where we test
the test-suite itself; the outer test snippet should be in charge of the
sub-test environment, not whatever mode the user happens to be running
in.

Reported-by: Son Luong Ngoc <sluongng@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t0000-basic.sh